ci: add path filtering to lint-stylelint workflow#59322
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
|
This is a shared workflow so the changes should rather be added in https://github.com/nextcloud/.github |
|
Yeah was trying to decide what order to do things in. I didn't want to push things there and risk having them propagate out to any other repos just yet. Ultimately this is an incremental step. Next one is #59326 (draft/WIP), to use a centralized/shared workflow for the path filtering. I figured once things settled down I'd port the final generic/shared bits to |
|
Though now that I see the patch model in nextcloud/.github#685 I suppose I'm going to have to take a bit of a hybrid approach during the interim until things get converged. Hmm. |
|
|
||
| if: always() | ||
|
|
||
| name: stylelint-summary |
There was a problem hiding this comment.
the summary should have the old name, so we don't need to adjust the branch CI requirements
|
@joshtrichards time to rebase and adjust the small comment? |
3 participants
Summary
The stylelint workflow currently runs unconditionally on every pull request, including PHP-only, docs-only, and other PRs that don't touch any CSS/SCSS/Vue files. This adds a changes job using
dorny/paths-filterand gates thelintjob behind it, matching the pattern already used bylint-eslint,lint-php, and others. A summary job is included for branch protection compatibility.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)